Repository navigation
[perf] Resolve method name before receiver type in reflection and AST resolvers - #8682
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoists the cheap
methodName === nullguard above the expensivenodeTypeResolver->getType()call on the receiver in three hot per-call resolvers. When the call name is unresolvable the methods bail, so the full PHPStan type resolution on the receiver was wasted on that path.ReflectionResolver::resolveMethodReflectionFromStaticCallReflectionResolver::resolveMethodReflectionFromMethodCallAstResolver::resolveClassMethodFromCallPure statement reorder, behaviour unchanged - the name check is independent of the resolved type. Matches the ordering the sibling
resolvePropertyReflectionFromPropertyFetchalready uses.Validated locally: ECS and PHPStan level 8 clean on both files, rules-tests/TypeDeclaration + rules-tests/DeadCode green (1765 tests).