Skip to content

[perf] Resolve method name before receiver type in reflection and AST resolvers #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 16, 2026
Merged

[perf] Resolve method name before receiver type in reflection and AST resolvers #8682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/PhpParser/AstResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ public function resolveClassMethodFromCall(MethodCall|StaticCall|NullsafeMethodC
return $this->resolveClassMethod($className, MethodName::CONSTRUCT);
}

$methodName = $this->nodeNameResolver->getName($call->name);
if ($methodName === null) {
return null;
}

$callerStaticType = ($call instanceof MethodCall || $call instanceof NullsafeMethodCall)
? $this->nodeTypeResolver->getType($call->var)
: $this->nodeTypeResolver->getType($call->class);
Expand All @@ -148,11 +153,6 @@ public function resolveClassMethodFromCall(MethodCall|StaticCall|NullsafeMethodC
return null;
}

$methodName = $this->nodeNameResolver->getName($call->name);
if ($methodName === null) {
return null;
}

return $this->resolveClassMethod($className, $methodName);
}

Expand Down
22 changes: 10 additions & 12 deletions src/Reflection/ReflectionResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ public function resolveMethodReflection(string $className, string $methodName, ?

public function resolveMethodReflectionFromStaticCall(StaticCall $staticCall): ?MethodReflection
{
$methodName = $this->nodeNameResolver->getName($staticCall->name);
if ($methodName === null) {
return null;
}

$objectType = $this->nodeTypeResolver->getType($staticCall->class);

if ($objectType instanceof ShortenedObjectType || $objectType instanceof AliasedObjectType) {
Expand All @@ -148,11 +153,6 @@ public function resolveMethodReflectionFromStaticCall(StaticCall $staticCall): ?
$classNames = $objectType->getObjectClassNames();
}

$methodName = $this->nodeNameResolver->getName($staticCall->name);
if ($methodName === null) {
return null;
}

$scope = $staticCall->getAttribute(AttributeKey::SCOPE);

foreach ($classNames as $className) {
Expand All @@ -167,20 +167,18 @@ public function resolveMethodReflectionFromStaticCall(StaticCall $staticCall): ?

public function resolveMethodReflectionFromMethodCall(MethodCall $methodCall): ?MethodReflection
{
$callerType = $this->nodeTypeResolver->getType($methodCall->var);
$methodName = $this->nodeNameResolver->getName($methodCall->name);
if ($methodName === null) {
return null;
}

$callerType = $this->nodeTypeResolver->getType($methodCall->var);
if ($callerType instanceof BenevolentUnionType) {
$callerType = TypeCombinator::removeFalsey($callerType);
}

$className = ClassNameFromObjectTypeResolver::resolve($callerType);
if ($className === null) {

return null;
}

$methodName = $this->nodeNameResolver->getName($methodCall->name);
if ($methodName === null) {
return null;
}

Expand Down
Loading