Remove duplicate Github actions for every PR #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll requests that target master branch.
prithvi514
requested review from
amortezaei and
petedannemann
and removed request for
a team
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
There was a problem hiding this comment.
This means people cannot target other branches in pull requests. I have been doing this recently as I have many branches that stack upon each other and this has made it easier to chunk up large features into several smaller PRs. Is there a way around this limitation?
There was a problem hiding this comment.
I wonder if something like this is what we want:
push:
branches:
- master
pull_request:There was a problem hiding this comment.
Yea, this sounds good.
petedannemann
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Github CI actions to trigger on pushing to master and for pull requests that target master branch.