Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate Github actions for every PR #166

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Remove duplicate Github actions for every PR #166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a279e4
Updating Github CI actions to trigger on pushing to master and for pu…
prithvi514 Nov 15, 2023
97ff690
Allow CI on pull requests targeting all branches.
prithvi514 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: ci

on: [push, pull_request]
on:
push:
branches:
- master
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means people cannot target other branches in pull requests. I have been doing this recently as I have many branches that stack upon each other and this has made it easier to chunk up large features into several smaller PRs. Is there a way around this limitation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if something like this is what we want:

push:
    branches:
      - master
  pull_request:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this sounds good.

branches:
- master


jobs:
Expand Down
Loading