Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement I/O-safe traits #84

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Implement I/O-safe traits #84

merged 6 commits into from
Aug 17, 2022

Conversation

notgull
Copy link
Member

@notgull notgull commented Aug 11, 2022 •
edited
Loading

This PR implements AsFd and AsSocket for Async<T>. In addition, TryFrom<OwnedFd/OwnedSocket is implemented for Async<T> and TryFrom<Async<T>> is implemented for OwnedFd/OwnedSocket, in order to mirror the From/Into<OwnedFd/OwnedSocket> impls in std but also considering that the operations are fallible in async-io.

See also: sunfishcode/io-lifetimes#38

taiki-e
taiki-e reviewed Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

Cargo.toml Outdated Show resolved Hide resolved
@notgull notgull mentioned this pull request Aug 15, 2022
Merged
taiki-e
taiki-e reviewed Aug 17, 2022
View reviewed changes
build.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit a20076f into smol-rs:master Aug 17, 2022
@taiki-e
Copy link
Collaborator

taiki-e commented Aug 17, 2022

Published in 1.8.0.

@taiki-e taiki-e mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @taiki-e