Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-974] data/httphandler/validators: Adding sorting to GET /users endpoint. #104

Merged
merged 10 commits into from
Nov 29, 2023
Merged

[SDP-974] data/httphandler/validators: Adding sorting to GET /users endpoint. #104

merged 10 commits into from
Nov 29, 2023

Conversation

ceciliaromao
Copy link
Contributor

What

Add sort and direction parameters to sort GET /users endpoint.

Why

Sort users according to query parameters.

Known limitations

N/A

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@ceciliaromao ceciliaromao self-assigned this Nov 21, 2023
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 21, 2023 21:08 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 21, 2023 21:08 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao marked this pull request as draft November 21, 2023 21:08
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 21, 2023 21:09 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 21, 2023 21:09 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao marked this pull request as ready for review November 21, 2023 21:13
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 21, 2023 21:21 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 21, 2023 21:21 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@reecexlm
Copy link
Collaborator

Thanks Maria! Would you mind adding some notes on how this has been tested? Also have you tested this in the deployed PR Preview environment? I believe that a FE is now deployed with each preview. is that correct @marwen-abid ?

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 22, 2023 20:55 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 22, 2023 20:55 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

marwen-abid
marwen-abid reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that we're creating a dependency where stellar-auth imports from internal package.

We want to avoid doing that because it creates a circular dependency and stellar-auth has remained a standalone package in the current version.

CHANGELOG.md Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 24, 2023 13:29 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 24, 2023 13:29 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

CaioTeixeira95
CaioTeixeira95 reviewed Nov 27, 2023
View reviewed changes
stellar-auth/pkg/auth/auth.go Outdated Show resolved Hide resolved
internal/serve/httphandler/user_handler.go Outdated Show resolved Hide resolved
stellar-auth/pkg/auth/authenticator_test.go Outdated Show resolved Hide resolved
stellar-auth/pkg/auth/authenticator.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 17:56 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 17:56 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 28, 2023 20:43 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 28, 2023 20:43 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

CaioTeixeira95
CaioTeixeira95 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the changes.

stellar-auth/pkg/auth/authenticator.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao had a problem deploying to Receiver Registration - E2E Integration Tests November 29, 2023 01:19 — with GitHub Actions Failure
@ceciliaromao ceciliaromao had a problem deploying to Anchor Integration Tests November 29, 2023 01:19 — with GitHub Actions Failure
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@ceciliaromao ceciliaromao changed the title [SDP-974] data/httphandler/validators/stellar-auth: Adding sorting to GET /users endpoint. [SDP-974] data/httphandler/validators: Adding sorting to GET /users endpoint. Nov 29, 2023
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 29, 2023 01:25 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 29, 2023 01:25 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests November 29, 2023 01:28 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests November 29, 2023 01:28 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr104.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr104.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr104.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao merged commit 7df3634 into develop Nov 29, 2023
6 checks passed
@ceciliaromao ceciliaromao deleted the sdp-974_sort-get-users branch November 29, 2023 01:45
@ceciliaromao ceciliaromao mentioned this pull request Feb 12, 2024
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaioTeixeira95 CaioTeixeira95 CaioTeixeira95 approved these changes

@marcelosalloum marcelosalloum Awaiting requested review from marcelosalloum

@ziyliu ziyliu Awaiting requested review from ziyliu

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

Assignees

@ceciliaromao ceciliaromao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceciliaromao @stellar-jenkins @reecexlm @marwen-abid @CaioTeixeira95