[SDP-974] data/httphandler/validators: Adding sorting to GET /users endpoint.

CHANGELOG.md

@@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
-> Place unreleased changes here.
+- Add sorting to `GET /users` endpoint [#104](https://github.com/stellar/stellar-disbursement-platform-backend/pull/104)
 
 ## [1.0.0](https://github.com/stellar/stellar-disbursement-platform-backend/compare/1.0.0-rc2...1.0.0)
 

internal/data/query_params.go

@@ -20,6 +20,8 @@ type SortField string
 
 const (
 	SortFieldName      SortField = "name"
+	SortFieldEmail     SortField = "email"
+	SortFieldIsActive  SortField = "is_active"
 	SortFieldCreatedAt SortField = "created_at"
 	SortFieldUpdatedAt SortField = "updated_at"
 )

internal/serve/httphandler/user_handler.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
+	"sort"
 
 	"github.com/stellar/go/support/http/httpdecode"
 	"github.com/stellar/go/support/log"
@@ -32,6 +33,18 @@ type UserActivationRequest struct {
 	IsActive *bool  `json:"is_active"`
 }
 
+type UserSorterByEmail []auth.User
+
+func (a UserSorterByEmail) Len() int           { return len(a) }
+func (a UserSorterByEmail) Swap(i, j int)      { a[i], a[j] = a[j], a[i] }
+func (a UserSorterByEmail) Less(i, j int) bool { return a[i].Email < a[j].Email }
+
+type UserSorterByIsActive []auth.User
+
+func (a UserSorterByIsActive) Len() int           { return len(a) }
+func (a UserSorterByIsActive) Swap(i, j int)      { a[i], a[j] = a[j], a[i] }
+func (a UserSorterByIsActive) Less(i, j int) bool { return a[i].IsActive }
+
 func (uar UserActivationRequest) validate() *httperror.HTTPError {
 	validator := validators.NewValidator()
 
@@ -275,6 +288,13 @@ func (h UserHandler) UpdateUserRoles(rw http.ResponseWriter, req *http.Request)
 }
 
 func (h UserHandler) GetAllUsers(rw http.ResponseWriter, req *http.Request) {
+	validator := validators.NewUserQueryValidator()
+	queryParams := validator.ParseParametersFromRequest(req)
+	if validator.HasErrors() {
+		httperror.BadRequest("request invalid", nil, validator.Errors).Render(rw)
+		return
+	}
+
 	ctx := req.Context()
 
 	token, ok := ctx.Value(middleware.TokenContextKey).(string)
@@ -290,10 +310,25 @@ func (h UserHandler) GetAllUsers(rw http.ResponseWriter, req *http.Request) {
 			httperror.Unauthorized("", err, nil).Render(rw)
 			return
 		}
-
 		httperror.InternalError(ctx, "Cannot get all users", err, nil).Render(rw)
 		return
 	}
 
+	// Order users
+	switch queryParams.SortBy {
+	case data.SortFieldEmail:
+		if queryParams.SortOrder == data.SortOrderDESC {
+			sort.Sort(sort.Reverse(UserSorterByEmail(users)))
+		} else {
+			sort.Sort(UserSorterByEmail(users))
+		}
+	case data.SortFieldIsActive:
+		if queryParams.SortOrder == data.SortOrderDESC {
+			sort.Sort(sort.Reverse(UserSorterByIsActive(users)))
+		} else {
+			sort.Sort(UserSorterByIsActive(users))
+		}
+	}
+
 	httpjson.RenderStatus(rw, http.StatusOK, users, httpjson.JSON)
 }