Use system mongocxx client if possible #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request. |
furushchev
force-pushed
the
fix-mongocxx
branch
from
8e5c5ec to
bc4f4bd
Compare
|
Looks good to me. |
|
@marc-hanheide want to check? |
k-okada
reviewed
Nov 1, 2017
| ${PROJECT_SOURCE_DIR}/include/mongo | ||
| ${CATKIN_DEVEL_PREFIX}/include/mongo) | ||
| else() | ||
| message(STATUS "Not Found System MongoClient. Downloading...") |
There was a problem hiding this comment.
are you assuming this is kinetic situation?
There was a problem hiding this comment.
@k-okada Yes. In indigo (=ubuntu14.04) system mongoclient library is used, in kinetic (=ubuntu16.04) mongoclient is downloaded and compiled from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for fix the issue #204.
In this pull request, I mainly fixed
CMakeLists.txtoflibmongocxx_rosto use system mongocxx client if it is found in system region or download and compile from source otherwise.In current situation, system mongocxx is used on ubuntu 14.04 and downloaded mongocxx is used on ubuntu 16.04.