Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add driver_station #47

Merged
merged 6 commits into from
Mar 17, 2019
Merged

Add driver_station #47

merged 6 commits into from
Mar 17, 2019

Conversation

Oasixer
Copy link
Contributor

@Oasixer Oasixer commented Mar 17, 2019 •
edited
Loading

Pull Request

Add driver_station package with a blank window to frc_control as per issue #48

Contribution Checklist

  • I have read the contributing guide.
  • I have referenced relevant issues.
  • I have labeled accordingly.
  • I have detailed my changes as much as possible.

Change Checklist

  • I have added tests.
  • I have added necessary documentation.
  • I have auto formatted using clang-format or yapf.

@Oasixer Oasixer self-assigned this Mar 17, 2019
@matthew-reynolds matthew-reynolds changed the title #13 added driver_station Add driver_station Mar 17, 2019
@matthew-reynolds matthew-reynolds self-requested a review March 17, 2019 15:32
matthew-reynolds
matthew-reynolds requested changes Mar 17, 2019
View reviewed changes
Copy link
Member

@matthew-reynolds matthew-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small nitpicks, nothing major. However please review the contributing guide and double check that the code has been run through yapf.

.gitignore Outdated Show resolved Hide resolved
driver_station/CMakeLists.txt Show resolved Hide resolved
driver_station/package.xml Outdated Show resolved Hide resolved
driver_station/package.xml Outdated Show resolved Hide resolved
@matthew-reynolds matthew-reynolds merged commit 3b589fc into melodic-devel Mar 17, 2019
@matthew-reynolds matthew-reynolds deleted the qt-driver-station branch March 17, 2019 15:58
@matthew-reynolds matthew-reynolds mentioned this pull request Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-reynolds matthew-reynolds matthew-reynolds approved these changes

Assignees

@Oasixer Oasixer

Labels
🚀 feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oasixer @matthew-reynolds