-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Improvements #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging when this check fails
…ders of the VegaLite component
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JackWilb
reviewed
Oct 16, 2024
packages/upset/src/components/ElementView/ElementVisualization.tsx
Outdated
Show resolved
Hide resolved
JakeWags
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. A few changes for clarity, but not blocks to merging.
packages/upset/src/components/Columns/Attribute/AttributePlots/MemoizedDensityVega.tsx
Show resolved
Hide resolved
packages/upset/src/components/ElementView/ElementVisualization.tsx
Outdated
Show resolved
Hide resolved
…ext to App to fix a variety of bugs
…t node in the node graph
JackWilb
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #334
Give a longer description of what this PR addresses and why it's needed
Improves performance across a variety of actions by reducing unnecessary re-renders. Includes:
getValuesFromRow
function inAttributeBar
with a memoized Recoil selectorVegaLite
component in element view sidebarElementSidebar
component unless it is openProvide pictures/videos of the behavior before and after these changes (optional)
No visible changes to behavior other than speedup
Have you added or updated relevant tests?
Have you added or updated relevant documentation?