Code

Performance Improvements#408

Code

Merged

NateLanza merged 35 commits intomainvisdesignlab/upset2:mainfrom 334-performancevisdesignlab/upset2:334-performanceCopy head branch name to clipboardOct 21, 2024

+978-2,727

Commits

Commits on Sep 24, 2024

• Add selector for attribute values in a row

  

  Nate Lanza

  committed
  2521034

  Copy full SHA for 2521034

• Use row attribute value selector to improve AttributeBar performance

  

  Nate Lanza

  committed
  f08aed3

  Copy full SHA for f08aed3

• Updates to AttributeBar comments & style

  

  Nate Lanza

  committed
  9fc352b

  Copy full SHA for 9fc352b

• Exclude element sidebar from DOM unless open

  

  Nate Lanza

  committed
  8cedadb

  Copy full SHA for 8cedadb

Commits on Sep 27, 2024

• Use callbacks for CollapseAllButton's functions

  

  Nate Lanza

  committed
  2963aa8

  Copy full SHA for 2963aa8

Commits on Oct 1, 2024

• Memoize getting intersections in the elementsSelector

  

  Nate Lanza

  committed
  c005960

  Copy full SHA for c005960

• Use recoil to memoize row computations

  

  Nate Lanza

  committed
  0cf5771

  Copy full SHA for 0cf5771

• Clean up unused imports for previous commit

  

  Nate Lanza

  committed
  5c12dc7

  Copy full SHA for 5c12dc7

• Bugfix for previous: get alttext gen working again

  

  Nate Lanza

  committed
  5fd3107

  Copy full SHA for 5fd3107

• Use selectors to memoize AttributeDropdown computations

  

  Nate Lanza

  committed
  3273e06

  Copy full SHA for 3273e06

Commits on Oct 3, 2024

• Add why-did-you-render package to dev mode

  

  Nate Lanza

  committed
  8059928

  Copy full SHA for 8059928

Commits on Oct 12, 2024

• Prevent AttributeBars from re-rendering on hover

  

  Nate Lanza

  committed
  bc81b09

  Copy full SHA for bc81b09

• Memoize props sent to VegaLite in DensityPlot to avoid unnecessary re-renders

  

  Nate Lanza

  committed
  a7937f7

  Copy full SHA for a7937f7

• Check attribute values in AttributeBar memo comparison func

  

  Nate Lanza

  committed
  0788948

  Copy full SHA for 0788948

• Remove unnecessary useRef for string prop

  

  Nate Lanza

  committed
  5c01982

  Copy full SHA for 5c01982

Commits on Oct 15, 2024

• Memoize element vis signalListeners to reduce unnecessary re-renders

  

  Nate Lanza

  committed
  232cb7e

  Copy full SHA for 232cb7e

• Memoize VegaLite props in ElementVis

  

  Nate Lanza

  committed
  b69ffb5

  Copy full SHA for b69ffb5

• Bugfix: re-export RenderRow type as it is used elsewhere

  

  Nate Lanza

  committed
  a3f6461

  Copy full SHA for a3f6461

• Bugfix: add an additional null check to attValuesSelector; remove logging when this check fails

  

  Nate Lanza

  committed
  e586615

  Copy full SHA for e586615

• Split density plots & memoize internally to minimize expensive re-renders of the VegaLite component

  

  Nate Lanza

  committed
  6841b04

  Copy full SHA for 6841b04

• Bugfix: handle potentially null data (bug only appears in prod build on netlify preview)

  

  Nate Lanza

  committed
  a98ef43

  Copy full SHA for a98ef43

• Bugfix for prev: null check & typecheck data before checking for 'sets' field

  

  Nate Lanza

  committed
  c848a62

  Copy full SHA for c848a62

• Bugfix for previous: tired brain no do logical operators

  

  Nate Lanza

  committed
  6be89e1

  Copy full SHA for 6be89e1

Commits on Oct 17, 2024

• Move provenance state converter from root to app

  

  Nate Lanza

  committed
  643e830

  Copy full SHA for 643e830

• Add upset config atom in App & sync it with the provenance state

  

  Nate Lanza

  committed
  57e7e35

  Copy full SHA for 57e7e35

Commits on Oct 18, 2024

• Revamp how multinet states are imported; move import & ProvenanceContext to App to fix a variety of bugs

  

  Nate Lanza

  committed
  87194c5

  Copy full SHA for 87194c5

• Bugfix: ensure ProvenanceVis never tries to find a nonexistent current node in the node graph

  

  Nate Lanza

  committed
  02af7c2

  Copy full SHA for 02af7c2

• Change App's rowsSelector to be truly responsive & not take UpsetConfig as a param

  

  Nate Lanza

  committed
  ab6866a

  Copy full SHA for ab6866a

• Use structuredClone instead of json stringification in ElementVis

  

  Nate Lanza

  committed
  fad6046

  Copy full SHA for fad6046

• Docs update for index.tsx

  

  Nate Lanza

  committed
  2d9fda8

  Copy full SHA for 2d9fda8

• Bugfix: wrong URL while setting up tests

  

  Nate Lanza

  committed
  9b38c8a

  Copy full SHA for 9b38c8a

Commits on Oct 21, 2024

• Organize App useEffects

  

  Nate Lanza

  committed
  2d8db46

  Copy full SHA for 2d8db46

• Update DataTable to import rows directly from selector & fix datatable test

  

  Nate Lanza

  committed
  4b767ba

  Copy full SHA for 4b767ba

• Add spinner while loading provenance (also fixes console warnings)

  

  Nate Lanza

  committed
  90b2d00

  Copy full SHA for 90b2d00

• Merge branch 'main' into 334-performance

  NateLanza

  authored
  50fc39e

  Copy full SHA for 50fc39e