Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback form: upload attachments #21115

Conversation

nbradbury
Copy link
Contributor

Partially addresses #21105

This PR is the first pass at adding attachment uploading to the feedback form. To test:

  • Tap Help on the Me page and ensure the "Contact email" is correct
  • Return to the Me page and tap "Send feedback"
  • Enter a message
  • Add a couple of attachments
  • Tap submit and verify it all works
  • When you get the email about the ticket, go to https://a8c.zendesk.com/agent/tickets/$ticketNumber and verify the attachments were added

A couple of caveats:

  • I'm not wild about having to use a "completion handler" to determine when all attachments have been uploaded. I hope to resolve this but the fact that Zendesk relies on callbacks may have tied my hands.
  • There is no preview of attachments (that may come later, but wasn't deemed high priority)
  • There isn't a way to cancel the attachment uploading. This is more of a priority, but again the fact that Zendesk relies on callbacks may be a problem.
attach.mp4

@nbradbury nbradbury added User Feedback Users need something added or fixed unit-tests-exemption labels Aug 6, 2024
@nbradbury nbradbury self-assigned this Aug 6, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Class ZendeskUploadHelper is missing tests, but unit-tests-exemption label was set to ignore this.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Aug 6, 2024

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21115-765f77f
Commit765f77f
Direct Downloadwordpress-prototype-build-pr21115-765f77f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21115-765f77f
Commit765f77f
Direct Downloadjetpack-prototype-build-pr21115-765f77f.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 40.58%. Comparing base (490dcf2) to head (765f77f).

Files Patch % Lines
...roid/ui/main/feedbackform/FeedbackFormViewModel.kt 0.00% 33 Missing ⚠️
...g/wordpress/android/support/ZendeskUploadHelper.kt 0.00% 15 Missing ⚠️
...ava/org/wordpress/android/support/ZendeskHelper.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           feature/feedback-form-attachments   #21115      +/-   ##
=====================================================================
- Coverage                              40.60%   40.58%   -0.03%     
=====================================================================
  Files                                   1533     1534       +1     
  Lines                                  70453    70494      +41     
  Branches                               11645    11653       +8     
=====================================================================
  Hits                                   28607    28607              
- Misses                                 39261    39302      +41     
  Partials                                2585     2585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury marked this pull request as ready for review August 7, 2024 11:07
@nbradbury
Copy link
Contributor Author

Although this could use improvement, I'm merging it as-is into the feature branch and will work on improvements separately. :shipit:

@nbradbury nbradbury merged commit e4fc976 into feature/feedback-form-attachments Aug 7, 2024
20 checks passed
@nbradbury nbradbury deleted the issue/21105-feedback-form-upload-attachments branch August 7, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-tests-exemption User Feedback Users need something added or fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants