-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback form: upload attachments #21115
Feedback form: upload attachments #21115
Conversation
…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-upload-attachments
…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-upload-attachments
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/feedback-form-attachments #21115 +/- ##
=====================================================================
- Coverage 40.60% 40.58% -0.03%
=====================================================================
Files 1533 1534 +1
Lines 70453 70494 +41
Branches 11645 11653 +8
=====================================================================
Hits 28607 28607
- Misses 39261 39302 +41
Partials 2585 2585 ☔ View full report in Codecov by Sentry. |
Although this could use improvement, I'm merging it as-is into the feature branch and will work on improvements separately. |
Partially addresses #21105
This PR is the first pass at adding attachment uploading to the feedback form. To test:
https://a8c.zendesk.com/agent/tickets/$ticketNumber
and verify the attachments were addedA couple of caveats:
attach.mp4