-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: nxp: add RT1060 EVKC support #83546
base: main
Are you sure you want to change the base?
Conversation
|
||
/* FLEXPWM not routed to LED on this EVK */ | ||
&flexpwm2_pwm3 { | ||
status = "disabled"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe would be also good to do /delete-node/ on the pwm leds nodes if there are no pwm leds on the board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This is a direct copy of the rev B dts. I want to review some stuff on this with the team.
I also have a local change for docs to discuss. I found one example in the tree that used tabs (which I personally like). There is also a consideration to change the default rev to something folks can actually buy.
@@ -0,0 +1,15 @@ | |||
/* | |||
* Copyright (c) 2022, Whisper.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add NXP copyright and year? If so, there are other files in the PR with NXP copyright missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this file needs it. I just copied it from the revB and made no changes. But I'll walk through the others to verify.
MIMXRT1060 EVK rev C initial support files. Signed-off-by: David Leach <[email protected]>
MIMXRT1060 EVK rev C initial support files.