Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython perf simplification #861

Merged
merged 14 commits into from
Nov 26, 2024

fixed bug in mock netCDF4

6fedebb
Select commit
Loading
Failed to load commit list.
Merged

Cython perf simplification #861

fixed bug in mock netCDF4
6fedebb
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 26, 2024 in 4s

2 new alerts

New alerts in code changed by this pull request

  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 91 in src/sisl/__init__.py

See this annotation in the file changed.

Code scanning / CodeQL

'import *' may pollute namespace Note

Import pollutes the enclosing namespace, as the imported module
sisl._core
Loading
does not define '__all__'.

Check notice on line 101 in src/sisl/io/siesta/_help.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.