Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython perf simplification #861

Merged
merged 14 commits into from
Nov 26, 2024

fixed bug in mock netCDF4

6fedebb
Select commit
Loading
Failed to load commit list.
Merged

Cython perf simplification #861

fixed bug in mock netCDF4
6fedebb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

86.97% (-0.01%) compared to 8559eda, passed because coverage increased by 0.01% when compared to adjusted base (86.95%)

View this Pull Request on Codecov

86.97% (-0.01%) compared to 8559eda, passed because coverage increased by 0.01% when compared to adjusted base (86.95%)

Details

Codecov Report

Attention: Patch coverage is 85.10638% with 56 lines in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (8559eda) to head (6fedebb).

Files with missing lines Patch % Lines
src/sisl/physics/sparse.py 44.18% 48 Missing ⚠️
src/sisl/io/siesta/_help.py 92.85% 6 Missing ⚠️
src/sisl/io/siesta/binaries.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   86.98%   86.97%   -0.01%     
==========================================
  Files         404      405       +1     
  Lines       52638    52792     +154     
==========================================
+ Hits        45785    45916     +131     
- Misses       6853     6876      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.