test(installer): update snapshot testing

[richardkeit]

Snapshot Tests not updated in release

[richardkeit]

@erwaxler , @bo1984 - if I can be troublesome, can this please be looked at?

As it is using pull_request_target as the event, it clones from main and not my feature branch. Therefore, I can never fix this test!

For example, my failing test runs against commit https://github.com/awslabs/landing-zone-accelerator-on-aws/actions/runs/11397091326/job/31711985976#step:2:67 which is main. What I find is that these automated tests don't actually validate the pull request itself, but rather main (already merged code given a false sense of suitability)

[erwaxler]

Hey @richardkeit , thanks for creating this! I will get this reviewed and merged into the code base internally. I will also follow-up on:

• Fixing the bug that allowed the snapshot to remain using v1.9.1
• Updating the GitHub action tests to use the source branch commit

Thanks as always for your continued support it is very much appreciated!

[richardkeit]

Assume this can be closed @erwaxler