-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit manufacturers #73 #112
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
- Coverage 89.33% 85.10% -4.23%
===========================================
Files 32 34 +2
Lines 1519 1853 +334
Branches 461 534 +73
===========================================
+ Hits 1357 1577 +220
- Misses 159 273 +114
Partials 3 3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well for me, just some comments on the code and unit test coverage. A few things I will leave for edit to avoid more conflicts.
Description
Edit a manufacturer logic. Dialog opens when edit icon clicked, which is prepopulated. Users can edit fields and sends patch request. Error handling in place to ensure name cannot be edited to one that already exists in database, that at least one change is made, and that required fields are not left blank
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #73