Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit manufacturers #73 #112

Merged
merged 22 commits into from
Nov 9, 2023
Merged

Edit manufacturers #73 #112

merged 22 commits into from
Nov 9, 2023

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Oct 30, 2023

Description

Edit a manufacturer logic. Dialog opens when edit icon clicked, which is prepopulated. Users can edit fields and sends patch request. Error handling in place to ensure name cannot be edited to one that already exists in database, that at least one change is made, and that required fields are not left blank

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #73

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the base branch from develop to delete-manufacturer-#72 October 30, 2023 10:41
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (9688e29) 89.33% compared to head (d97f0b5) 85.10%.
Report is 30 commits behind head on develop.

❗ Current head d97f0b5 differs from pull request most recent head 941052f. Consider uploading reports for the commit 941052f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #112      +/-   ##
===========================================
- Coverage    89.33%   85.10%   -4.23%     
===========================================
  Files           32       34       +2     
  Lines         1519     1853     +334     
  Branches       461      534      +73     
===========================================
+ Hits          1357     1577     +220     
- Misses         159      273     +114     
  Partials         3        3              
Files Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
...anufacturer/deleteManufacturerDialog.component.tsx 100.00% <100.00%> (ø)
src/manufacturer/manufacturer.component.tsx 93.33% <92.00%> (-6.67%) ⬇️
src/mocks/handlers.ts 95.86% <89.28%> (-1.60%) ⬇️
src/api/manufacturer.tsx 82.27% <83.07%> (+3.70%) ⬆️
src/manufacturer/manufacturerDialog.component.tsx 50.50% <50.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review November 2, 2023 11:03
@joelvdavies joelvdavies mentioned this pull request Nov 7, 2023
4 tasks
Base automatically changed from delete-manufacturer-#72 to develop November 8, 2023 17:08
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for me, just some comments on the code and unit test coverage. A few things I will leave for edit to avoid more conflicts.

src/app.types.tsx Show resolved Hide resolved
src/manufacturer/manufacturer.component.tsx Show resolved Hide resolved
src/api/manufacturer.tsx Outdated Show resolved Hide resolved
src/api/manufacturer.tsx Outdated Show resolved Hide resolved
src/api/manufacturer.tsx Outdated Show resolved Hide resolved
src/app.types.tsx Outdated Show resolved Hide resolved
src/mocks/handlers.ts Show resolved Hide resolved
@joshuadkitenge joshuadkitenge removed their request for review November 9, 2023 12:16
@joelvdavies joelvdavies self-requested a review November 9, 2023 14:00
src/manufacturer/manufacturerDialog.component.test.tsx Outdated Show resolved Hide resolved
src/api/manufacturer.tsx Outdated Show resolved Hide resolved
@joelvdavies joelvdavies self-requested a review November 9, 2023 14:25
@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit aec47ce into develop Nov 9, 2023
3 checks passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the edit-manufacturers-#73 branch November 9, 2023 14:27
@joelvdavies joelvdavies mentioned this pull request Nov 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an operator/admin, I want to be able to edit manufacturers
2 participants