Change address fields #117

[MatteoGuarnaccia5]

Description

Changed address fields so that it can be used internationally. Updated tests accordingly

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage
• {more steps here}

Agile board tracking

to be merged in only when ral-facilities/inventory-management-system-api#85 (comment) merged in
and to be merged in at the same time as ral-facilities/inventory-management-system-api#108
closes #117

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83b17a6) 91.91% compared to head (c53efea) 91.87%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
- Coverage    91.91%   91.87%   -0.04%     
===========================================
  Files           36       36              
  Lines         2077     2055      -22     
  Branches       602      610       +8     
===========================================
- Hits          1909     1888      -21     
+ Misses         166      165       -1     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelvdavies]

A few things I noticed right now, with the types, currently if something is empty in the add dialogue e.g. the town it sends null

Ideally this would instead use undefined in typescript so that it isn't sent at all in the request. Its the same sort of thing with the edit requests.

The address display also needs some sort of logic when rendering as null fields appear like

[joelvdavies]

A couple more type related things. Also could the order of the fields be modified in the dialog/when displaying to have country after county, instead of before the first address line

as that is more standard.

[joelvdavies]

Sorry I don't think the comment I made was clear on what to remove.

[joshuadkitenge]

You currently have two useState for setting the manufacturer details in the manufacturer component . You should only need one useState. (setManufacturer and setSelectedManufacturer)

[joelvdavies]

One last note on the types - also speaking to Joshua, we need to merge
ral-facilities/inventory-management-system-api#115 and #128 first as the user feedback is coming up.

Also saw this which is a good sign