Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete manufacturer #72 #97

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Oct 16, 2023

Description

Enables users to delete manufacturers. Manufacturers that are a part of a Catalogue Item cannot be deleted and if the user tries to an appropriate error message will be shown

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Check that deleting a manufacturer that is part of an catalogue item is handled

Agile board tracking

closes #72

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the base branch from develop to add-manufacturers-#68 October 16, 2023 08:02
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (9688e29) 89.33% compared to head (8d9b3ab) 88.91%.
Report is 18 commits behind head on develop.

❗ Current head 8d9b3ab differs from pull request most recent head de6c201. Consider uploading reports for the commit de6c201 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
- Coverage    89.33%   88.91%   -0.43%     
===========================================
  Files           32       32              
  Lines         1519     1524       +5     
  Branches       461      443      -18     
===========================================
- Hits          1357     1355       -2     
- Misses         159      166       +7     
  Partials         3        3              
Files Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
...c/manufacturer/addManufacturerDialog.component.tsx 100.00% <100.00%> (ø)
...anufacturer/deleteManufacturerDialog.component.tsx 100.00% <100.00%> (ø)
src/api/manufacturer.tsx 88.88% <93.54%> (+10.31%) ⬆️
src/mocks/handlers.ts 94.44% <86.36%> (-3.02%) ⬇️
src/manufacturer/manufacturer.component.tsx 75.00% <66.66%> (-25.00%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review October 16, 2023 09:56
@joshuadkitenge joshuadkitenge requested review from joelvdavies and removed request for joshuadkitenge November 6, 2023 10:01
@joelvdavies joelvdavies mentioned this pull request Nov 7, 2023
4 tasks
Base automatically changed from add-manufacturers-#68 to develop November 8, 2023 10:07
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things, and some missing coverage. There are also some conflicts, and add is broken but I suspect that would be fixed by merging develop in. Edit will also need this merged into it afterwards.

src/api/manufacturer.tsx Outdated Show resolved Hide resolved
src/mocks/handlers.ts Outdated Show resolved Hide resolved
src/manufacturer/manufacturer.component.tsx Show resolved Hide resolved
src/manufacturer/deleteManufacturerDialog.component.tsx Outdated Show resolved Hide resolved
cypress/e2e/manufacturer/manufacturer.cy.tsx Outdated Show resolved Hide resolved
@joelvdavies joelvdavies self-requested a review November 8, 2023 16:38
@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit 8869952 into develop Nov 8, 2023
1 check passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the delete-manufacturer-#72 branch November 8, 2023 17:08
@joelvdavies joelvdavies mentioned this pull request Nov 9, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an admin, I want to be able to delete manufacturers
2 participants