-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete manufacturer #72 #97
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #97 +/- ##
===========================================
- Coverage 89.33% 88.91% -0.43%
===========================================
Files 32 32
Lines 1519 1524 +5
Branches 461 443 -18
===========================================
- Hits 1357 1355 -2
- Misses 159 166 +7
Partials 3 3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things, and some missing coverage. There are also some conflicts, and add is broken but I suspect that would be fixed by merging develop in. Edit will also need this merged into it afterwards.
Description
Enables users to delete manufacturers. Manufacturers that are a part of a Catalogue Item cannot be deleted and if the user tries to an appropriate error message will be shown
Testing instructions
Agile board tracking
closes #72