Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to the pilot repository #37

Merged
merged 4 commits into from
May 8, 2024

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 8, 2024

And also clear out the CitC and Magic Castle examples as they are not useful here

Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few polishing suggestions. Might be good to check if any script in this repo still uses EESSI_PILOT_VERSION

Bioconductor/run.sh Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we want to keep running tests for the pilot repo? Maybe only once per day or week. Thus we would notice if the repository doesn't work anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of work as you have to update the tests anyway since the init script now redirects you to software.eessi.io

OpenFOAM/run.sh Outdated Show resolved Hide resolved
GROMACS/run.sh Outdated Show resolved Hide resolved
TensorFlow/run.sh Outdated Show resolved Hide resolved
@ocaisa ocaisa requested a review from trz42 May 8, 2024 21:14
Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@trz42 trz42 merged commit efbdb26 into EESSI:main May 8, 2024
5 checks passed
@ocaisa ocaisa deleted the pilot_cleanout branch May 8, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants