Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/packed-join-abstractions #993 +/- ##
=================================================================
Coverage ? 87.35%
=================================================================
Files ? 96
Lines ? 32389
Branches ? 0
=================================================================
Hits ? 28295
Misses ? 4094
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 8.8%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | rust_rule_insert_loop[ops100000_funcs2000] |
48.8 ms | 54.3 ms | -10.2% |
| ❌ | rust_rule_insert_loop[ops100000_funcs0] |
49.2 ms | 54.6 ms | -10.01% |
| ❌ | rust_rule_insert_loop[ops100000_funcs200] |
49.1 ms | 54.4 ms | -9.69% |
| ❌ | rust_rule_tableaction_hot_path[facts50000_funcs200] |
25.7 ms | 28 ms | -8.45% |
| ❌ | rust_rule_insert_loop[ops1000_funcs2000] |
627.5 µs | 681.3 µs | -7.9% |
| ❌ | rust_rule_insert_loop[ops1000_funcs0] |
622.9 µs | 675.2 µs | -7.75% |
| ❌ | rust_rule_insert_loop[ops1000_funcs200] |
636 µs | 688.1 µs | -7.57% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/packed-trie-split-01-residual-index (1e5392d) with codex/packed-join-abstractions (7faf41b)2
Footnotes
-
227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
codex/packed-join-abstractions(8e85a68) during the generation of this report, so 9537fab was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
8f5b779 to
785b85c
Compare
yihozhang
left a comment
There was a problem hiding this comment.
We can address the nits in the end with a different PR if that's easier.
785b85c to
8c76e13
Compare
8c76e13 to
1e5392d
Compare
This PR is part of an eight-PR stack that jointly replaces #959.
Stack base: #969
Replacement stack:
Validation on the complete stack:
Layer 1 of 8.
Adds allocation-free residual index primitives in a dedicated implementation file. The executor wiring is intentionally deferred to #998 so this abstraction can be reviewed separately.
Non-test diff: +283 / -0.