Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/packed-trie-split-02-packed-cache #995 +/- ##
========================================================================
Coverage 87.36% 87.36%
========================================================================
Files 96 96
Lines 32389 32389
========================================================================
+ Hits 28296 28297 +1
+ Misses 4093 4092 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
3dea2ab to
892e543
Compare
9b36649 to
b896bf9
Compare
| } | ||
|
|
||
| impl PreparedJoinIndexes { | ||
| fn new(db: &Database, atoms: &Arc<DenseIdMap<AtomId, Atom>>, stages: &JoinStages) -> Self { |
There was a problem hiding this comment.
I realize I should have read this function first, which explains the high-level structure of this file. Maybe leave a note in the top-level doc that someone new to this file should start with this function
| Uncacheable, | ||
| } | ||
|
|
||
| struct PreparedIndexSlot { |
There was a problem hiding this comment.
I find this struct hard to understand, probably because all of its uses are in execute.rs (in a later PR) via direct field access, and it lacks any associated methods to encapsulate operations over PreparedIndexSlot.
b896bf9 to
397f205
Compare
8cfec0f to
05470c4
Compare
05470c4 to
8046fd0
Compare
This PR is part of an eight-PR stack that jointly replaces #959.
Stack base: #969
Replacement stack:
Validation on the complete stack:
Layer 3 of 8.
Adds execution-scoped prepared-index state, continuation caches, and tail-mask preparation in a dedicated implementation file. The executor wiring is intentionally deferred to #998.
Non-test diff: +473 / -0.