Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/packed-trie-split-04-probes #997 +/- ##
=====================================================================
+ Coverage 87.34% 87.37% +0.03%
=====================================================================
Files 96 96
Lines 32369 32369
=====================================================================
+ Hits 28273 28284 +11
+ Misses 4096 4085 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
4b27e6a to
fc12fe5
Compare
fc12fe5 to
9059f3e
Compare
9059f3e to
9ccc399
Compare
8fd0e9c to
c6a0f67
Compare
yihozhang
left a comment
There was a problem hiding this comment.
Two thoughts:
materialization_is_live_in_tailmay repeat the same analysis even when the variable ordering is unchanged- Sibling branches do not share analysis results, even though they may share the same (updated) variable ordering from DVO.
The first one is a low-hanging fruit IMO. We can follow up on them and benchmark the actual cost before deciding whether optimization is worthwhile.
c6a0f67 to
0478405
Compare
0478405 to
802a93c
Compare
c4b9bb4 to
c818bc2
Compare
c818bc2 to
199d107
Compare
|
+1... I think we should look at sharing some of that in a follow-up PR. Definite potential low-hanging fruit. |
199d107 to
ec540ae
Compare
ec540ae to
3c94cc2
Compare
This PR is part of an eight-PR stack that jointly replaces #959.
Stack base: #969
Replacement stack:
Validation on the complete stack:
Layer 5 of 8.
Adds join-tail analysis, binding-state projection, ordering helpers, and worker-local state in a dedicated implementation file. The executor wiring is intentionally deferred to #998.
Non-test diff: +633 / -0.