Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## codex/packed-trie-split-05-join-tail #998 +/- ##
========================================================================
- Coverage 87.36% 87.28% -0.09%
========================================================================
Files 96 101 +5
Lines 32369 33305 +936
========================================================================
+ Hits 28280 29070 +790
- Misses 4089 4235 +146 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 8.68%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | tests[python_array_optimize] |
1.1 s | 1.3 s | -10.39% |
| ❌ | tests[typeinfer] |
115.8 ms | 124.5 ms | -6.95% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/packed-trie-split-06-executor (eff0c6c) with codex/packed-trie-split-05-join-tail (3c94cc2)
Footnotes
-
227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
ce72f92 to
f5e2783
Compare
f5e2783 to
e002afb
Compare
e002afb to
feb28fb
Compare
feb28fb to
f2f3dc1
Compare
f2f3dc1 to
f55562c
Compare
f55562c to
0594652
Compare
| let can_use_catalog = root_range.is_some() | ||
| && all_cacheable | ||
| && constraints.is_empty() | ||
| && !info.table.has_stale_rows() |
There was a problem hiding this comment.
Do we need this condition? We used to not need info.table.has_stale_rows() and instead do a filter_live() when scanning the subset.
Similarly for constraints.is_empty()
There was a problem hiding this comment.
Added some tests and confirmed that this is required, as is. I agree it's a bit gross.
0594652 to
266d491
Compare
266d491 to
0bdbc87
Compare
0bdbc87 to
49ec3a0
Compare
fc2b24e to
7e0ebe8
Compare
c250c01 to
0364148
Compare
0364148 to
eff0c6c
Compare
This PR is part of an eight-PR stack that jointly replaces #959.
Stack base: #969
Replacement stack:
Validation on the complete stack:
Layer 6 of 8.
Wires the supporting abstractions into generic-join execution and switches the executor to packed arena tries. Unit tests live in a separate execute_tests.rs file; end-to-end coverage remains in the crate test module.
Diff (including tests): +3130 / -2276, net +854.